This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Add IFileInfo overloads for SendFileAsync. #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| using (var fileContent = file.CreateReadStream()) | ||
| { | ||
| fileContent.Seek(offset, SeekOrigin.Begin); |
There was a problem hiding this comment.
Is the stream always seekable?
|
Small comment around seek-ability of the stream. We should probably throw if we can't seek and the index isn't 0. |
|
and don't seek if the offset is 0 |
Tratcher
force-pushed
the
tratcher/sendfile
branch
from
c0ef388 to
b08a3aa
Compare
|
🆙📅 Seek will throw if it's not seekable. No need to add our own exception unless it becomes a frequent point of confusion. |
Tratcher
force-pushed
the
tratcher/sendfile
branch
from
b08a3aa to
04e9da4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#527 @davidfowl @lodejard @khellang