This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Obsolete Auth 1.0 #806
Closed
Obsolete Auth 1.0 #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,21 +9,25 @@ namespace Microsoft.AspNetCore.Http.Authentication | |||
| /// <summary> | |||
| /// Used to store the results of an Authenticate call. | |||
| /// </summary> | |||
| [Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470")] | |||
There was a problem hiding this comment.
This is the pattern we usually use for obsolete messages. https://github.com/aspnet/Home/wiki/Engineering-guidelines#breaking-changes cc @Eilon
There was a problem hiding this comment.
Yeah this was mostly a placeholder for now, we have some time to craft the final message, since I can't check in this PR until I've updated all the downstream repos
13 tasks
15 tasks
|
Replaced by #866 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will go in when Security switches over to Auth 2.0 (this will require all Auth usages to switch over to 2.0 as well)