This repository was archived by the owner on Nov 20, 2018. It is now read-only.
Add DefaultScheme, remove single fallback #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Jul 7, 2017
kevinchalet
reviewed
Jul 7, 2017
| @@ -170,14 +130,6 @@ public virtual void AddScheme(AuthenticationScheme scheme) | |||
| { | |||
| _requestHandlers.Add(scheme); | |||
| } | |||
| if (typeof(IAuthenticationSignInHandler).IsAssignableFrom(scheme.HandlerType)) | |||
There was a problem hiding this comment.
Its consistent with IAuthenticationRequestHandler, all AuthenticationHandlers implement Authenticate/Challenge/Forbid. We have one handler that implements SignIn, and two that implement SignOut.
The real difference is that IAuthenticationRequestHandler is still used and can be justified by performance reasons (AuthenticationMiddleware.Invoke avoids instantiating new handlers that don't implement IAuthenticationRequestHandler).
IAuthenticationSignInHandler and IAuthenticationSignOutHandler are now dead code with no use. I can't find any technical reason to keep them. It makes logging a PITA for implementers, it requires a cast for every request and offers 0 benefit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aspnet/Security#1287
@Tratcher @davidfowl @danroth27