Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

Don't wait indefinitely for requests to drain #301

Closed
Tratcher opened this issue Jan 24, 2017 · 2 comments
Closed

Don't wait indefinitely for requests to drain #301

Tratcher opened this issue Jan 24, 2017 · 2 comments
Assignees
@Tratcher
Labels
3 - Done bug patch-approved
Milestone
1.1.1

Comments

@Tratcher
Copy link
Member

Backport to 1.1.1 @muratg
#298
@Tratcher Tratcher self-assigned this Jan 24, 2017
Tratcher added a commit that referenced this issue Jan 24, 2017
@Tratcher
#301 Add a timeout for draining requests on shutdown
b379e63
This was referenced Jan 24, 2017
Closed
Closed
@muratg muratg added this to the 1.1.1 milestone Jan 25, 2017
Tratcher added a commit that referenced this issue Feb 7, 2017
@Tratcher
#301 Add a timeout for draining requests on shutdown
83837a9
@Tratcher Tratcher mentioned this issue Feb 7, 2017
Merged
@Tratcher Tratcher closed this as completed Feb 8, 2017
@Eilon Eilon reopened this Feb 8, 2017
@Eilon
Copy link
Member

Eilon commented Feb 8, 2017

Re-opening because this not yet approved.

@Eilon
Copy link
Member

Eilon commented Feb 8, 2017

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

@Tratcher Tratcher closed this as completed Feb 8, 2017
@Eilon Eilon added the bug label Feb 8, 2017
@danroth27 danroth27 changed the title [1.1.1 patch] Don't wait indefinitely for requests to drain Don't wait indefinitely for requests to drain Mar 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
3 - Done bug patch-approved
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
3 participants
@Eilon @muratg @Tratcher