Skip to content
This repository was archived by the owner on Mar 19, 2019. It is now read-only.

[Patch 2.0.x] ArgumentNullException("chars") is thrown when iterating HeaderDictionary #410

Closed
muratg opened this issue Nov 1, 2017 · 4 comments
Closed

[Patch 2.0.x] ArgumentNullException("chars") is thrown when iterating HeaderDictionary #410

muratg opened this issue Nov 1, 2017 · 4 comments
Assignees
@Tratcher
Labels
3 - Done bug patch-approved
Milestone
2.0.6

Comments

@muratg
Copy link

muratg commented Nov 1, 2017

Original issue is here and is fixed.

We'd like to propose this for a patch release.
@muratg muratg modified the milestones: 2.0, 2.0.2 Nov 1, 2017
@muratg
Copy link
Author

muratg commented Nov 1, 2017 •
edited
Loading

cc @Eilon @Tratcher @mikeharder

This is a candidate for 2.0.4.

@muratg muratg modified the milestones: 2.0.4, 2.0.5 Nov 13, 2017
@Tratcher Tratcher modified the milestones: 2.0.5, 2.0.6 Dec 7, 2017
@Eilon
Copy link
Member

Eilon commented Jan 17, 2018

This patch is approved for the Feb 2018 patch. Please send a PR to the appropriate branch, get it reviewed, and merge.

Please consider adding a quirks-mode switch for this change.

Tratcher added a commit that referenced this issue Jan 17, 2018
@Tratcher
Fix issue reading empty known headers #410
1bced59
@Tratcher Tratcher mentioned this issue Jan 17, 2018
Merged
@Tratcher
Copy link
Member

@Eilon I'm not planning to add a quirk flag for this behavior. The error is very disruptive and the fix is very low risk. See the linked PR.

@Eilon
Copy link
Member

Eilon commented Jan 17, 2018

@Tratcher yeah I think that's reasonable here. Thanks for considering it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
3 - Done bug patch-approved
Projects
None yet
Milestone
2.0.6
Development

No branches or pull requests
3 participants
@Eilon @muratg @Tratcher