This repository was archived by the owner on Mar 19, 2019. It is now read-only.
React to Logging API changes #175
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,7 +153,7 @@ internal unsafe Request(RequestContext httpContext, NativeRequestContext memoryB | |||
|
|
|||
| if (_requestContext.Logger.IsEnabled(LogLevel.Debug)) | |||
| { | |||
| RequestContext.Logger.LogDebug(new ReceiveRequestLogContext(this)); | |||
| RequestContext.Logger.LogDebug(new ReceiveRequestLogContext(this).ToString()); | |||
There was a problem hiding this comment.
Why are you calling ToString on the structure?
BrennanConroy
force-pushed
the
brecon/logapi
branch
2 times, most recently
from
9dc1724 to
58af4c7
Compare
|
|
||
| public IEnumerator<KeyValuePair<string, object>> GetEnumerator() | ||
| { | ||
| return new List<KeyValuePair<string, object>> |
There was a problem hiding this comment.
Enumrable.Range(0,7).Select(i=>this[i]) ?
There was a problem hiding this comment.
or for (i++) { yield return this[i]; }
BrennanConroy
force-pushed
the
brecon/logapi
branch
from
58af4c7 to
247c46d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aspnet/Logging#331