This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Don't send chunked responses for HEAD requests #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesarblum
approved these changes
Jun 24, 2017
| Assert.False(response.Content.Headers.Contains("Content-Length")); | ||
| Assert.Equal(0, response.Content.Headers.Count()); | ||
|
|
||
| // Send a second request to check for connection corruption. |
There was a problem hiding this comment.
nit: change the comment to "to check that the connection wasn't corrupted." I was here wondering why the connection would be corrupted and how that code was checking that 😝
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#339
HEAD requests don't have response bodies, but they do emulate GET requests that may. HttpSysServer was assuming that the emulated GET request would result in a chunked response so it included the Transfer-Encoding: chunked header. However, it forgot to suppress the chunked terminator. This didn't show up in the tests because they weren't expecting additional data on the connection, and they also weren't re-using connections.
Rather than assuming chunking, it now omits the headers and pretends it's a content-length 0 response.