Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Prevent users breakpoints from being hit twice on debug #102

Closed
NTaylorMullen opened this issue Mar 23, 2016 · 8 comments
Closed

Prevent users breakpoints from being hit twice on debug #102

NTaylorMullen opened this issue Mar 23, 2016 · 8 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

Today when a users debugs their application via IISExpress (F5 in VisualStudio) their site gets hit with two requests (breakpoints get hit twice). One debug request to start the application, and then a second from the started web browser.

I believe VisualStudio currently sends the first request with verb "Debug". "Debug" seems too generic (in my opinion) to be baked directly into IISIntegration. We should consider creating a custom Visual Studio specific debug verb that indicates a request is to boot the application/for debug; that way we can eat it prior to it reaching the users application.

This was initially filed over in tooling here.

@NTaylorMullen NTaylorMullen changed the title Stop hitting user breakpoints twice on debug Prevent users breakpoints from being hit twice on debug Mar 23, 2016
@Eilon
Copy link
Member

Eilon commented Mar 23, 2016

cc @blowdart because presumably we'd need to ensure that this is safe for a deployed site.

Once we're sure we have a solid design for this, we can assign.

@blowdart
Copy link
Member

Oh is that why this is happening? I noticed that a couple of weeks back. This might be better addressed by getting VS to behave properly. I'm leery of adding new verbs, especially when folks might not be running under IIS Express

@blowdart
Copy link
Member

Rather than add another verb could we not change the Command header that's sent from IIS so we know we can ignore it if necessary?

I don't think IISIntegration should support DEBUG by default. It's one of those verbs that should be blocked by default.

@NTaylorMullen
Copy link
Contributor Author

/cc @BillHiebert

@Tratcher
Copy link
Member

Latest proposal: Have ANCM filter out the DEBUG request if the debugger is attached.

@Tratcher
Copy link
Member

An auto-start option (#161) may also remove the need for the DEBUG request.

@BillHiebert
Copy link

To make this work we would need to change the way we launch the debugger to attach to IIS Express first (so ANCM filters the debug verb), and then send the debug request and have the debugger attach to the spawned process

@Tratcher
Copy link
Member

We've opted to have the middleware filter out this request for v1.0. Post 1.0 the plan is to replace the DEBUG request with #161 (auto-start).

@Tratcher Tratcher assigned Tratcher and unassigned pan-wang May 25, 2016
jkotalik pushed a commit that referenced this issue Dec 8, 2017
…le support; fix client disconnect and app_offline issues (#102)

resubmit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants