Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Move PathBase from Kestrel to Middleware #236

Closed
Tratcher opened this issue Jul 19, 2016 · 4 comments
Closed

Move PathBase from Kestrel to Middleware #236

Tratcher opened this issue Jul 19, 2016 · 4 comments
Assignees
Milestone

Comments

@Tratcher
Copy link
Member

Right now UseIISIntegration takes the ASPNETCORE_APPL_PATH and adds it to the prefix registered with Kestrel so that Kestrel will split the path and path base. @davidfowl doesn't like the path base feature in Kestrel because it does not reject request from other paths. Assuming the feature gets removed, UseIISIntegration should handle the path logic via middleware instead.

Create a new middleware that's a combination of MapPath and UseWhen that splits path into path and path base like map, but continues the pipeline like UseWhen. It should also undo at the end like MapPath. This should be an independent middleware (UsePathBase("/base")) because Nginx has the same problem.

@Tratcher
Copy link
Member Author

RE: aspnet/Hosting#815

@muratg
Copy link
Contributor

muratg commented Jul 25, 2016

@davidfowl How much do you care about this?

cc @JunTaoLuo heads-up :)

@muratg
Copy link
Contributor

muratg commented Aug 10, 2016

Let's copy the feature to the middleware and keep the one in Kestrel, because removal would be a breaking change in 1.1.

Let's remove the one in Kestrel in 2.0. @JunTaoLuo, could you file a bug in 2.0.0 milestone in Kestrel?

@JunTaoLuo
Copy link
Contributor

Removal of Kestrel feature tracked in aspnet/KestrelHttpServer#1050

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants