Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Provide UserClaimsPrincipalFactory<TUser> #617

Closed
tugberkugurlu opened this issue Nov 4, 2015 · 7 comments
Closed

Provide UserClaimsPrincipalFactory<TUser> #617

tugberkugurlu opened this issue Nov 4, 2015 · 7 comments
Labels
3 - Done enhancement
Milestone
2.0.0

Comments

@tugberkugurlu
Copy link
Contributor

Currently, IUserClaimsPrincipalFactory<TUser> has an implementation as UserClaimsPrincipalFactory<TUser, TRole>. However, this is not convinent for implementations which don't support IRoleStore<TRole>. Providing UserClaimsPrincipalFactory<TUser> would be great.
@tugberkugurlu
Copy link
Contributor Author

Happy to PR for this if this sounds reasonable.

@HaoK
Copy link
Member

HaoK commented Nov 7, 2015

Feel free to submit a PR for this sure :)

@rustd rustd added this to the 3.0.0-rc2 milestone Nov 11, 2015
@rustd rustd assigned HaoK and unassigned HaoK Nov 11, 2015
@rustd
Copy link

rustd commented Nov 11, 2015

#581

@rustd rustd modified the milestones: Backlog, 3.0.0-rc2 Dec 7, 2015
@HaoK HaoK removed their assignment Dec 9, 2015
@ghost
Copy link

ghost commented Apr 10, 2016

Any progress on this? We should also have IServiceCollection.AddIdentity<TUser> without having to specify TRole.

@ghost ghost mentioned this issue Apr 10, 2016
Closed
tugberkugurlu added a commit to tugberkugurlu/Identity that referenced this issue Sep 1, 2016
@tugberkugurlu
added UserClaimsPrincipalFactoryOfTUser, fixes aspnet#617
94da20b
@tugberkugurlu tugberkugurlu mentioned this issue Sep 1, 2016
Closed
1 task
@HaoK HaoK removed this from the Backlog milestone Nov 18, 2016
@HaoK
Copy link
Member

HaoK commented Nov 18, 2016

@blowdart we should discuss this in triage again

@HaoK
Copy link
Member

HaoK commented Aug 31, 2017

This was done in 2.0 to support roles being optional

@HaoK HaoK closed this as completed Aug 31, 2017
@HaoK HaoK added this to the 2.0.0 milestone Aug 31, 2017
@HaoK
Copy link
Member

HaoK commented Aug 31, 2017

Done via #1269

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - Done enhancement
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@tugberkugurlu @rustd @HaoK