Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Remove ClaimsPrincipal extensions, replace with instance #701

Closed
wants to merge 4 commits into from
Closed

Remove ClaimsPrincipal extensions, replace with instance #701

wants to merge 4 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Jan 4, 2016

  • Removes static GetUserId/GetUserName/IsSigned in from ClaimsPrincipal
  • Replaced with SignInManager.GetUserId/GetUserName/IsSignedIn/GetUserAsync which accomplish the same thing but eliminates statics, and instead respect IdentityOptions.ClaimsIdentity for the claim types
  • Cleaned up SecurityStamp validator to use SignInManager/IOptions as a service

cc @divega @blowdart @rustd

@HaoK
Copy link
Member Author

HaoK commented Jan 4, 2016

Fixes #663

@rustd
Copy link

rustd commented Jan 5, 2016

@HaoK Can you please make the changes in the templates repo for these new APIs as well?

@rustd
Copy link

rustd commented Jan 5, 2016

Can you post to the announcements repo as well about this change.

@HaoK HaoK mentioned this pull request Jan 6, 2016
Closed
@HaoK
Copy link
Member Author

HaoK commented Jan 13, 2016

Move GetUserId/GetUserName to UserManager

@HaoK
Copy link
Member Author

HaoK commented Jan 14, 2016

2dade94

@HaoK HaoK closed this Jan 14, 2016
@HaoK HaoK deleted the haok/1-4id branch June 10, 2016 22:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoK @rustd @dnfclas