Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Rename app modules to follow convention *.module.ts #1228

Closed
kubaszumiato opened this issue Aug 25, 2017 · 2 comments
Closed

Rename app modules to follow convention *.module.ts #1228

kubaszumiato opened this issue Aug 25, 2017 · 2 comments

Comments

@kubaszumiato
Copy link

I was struggling to set up AngularCLI to generate components for my Angular app with the newest templates, there is a small trick that I had to do to make it recognize the main app module. I had to rename the app.module.browser.ts to app.browser.module.ts.

Is there any reason for such convention of modules' files naming? Angular team recommendations for naming of modules is with module.ts suffix, could you change this in your templates to follow this recommendation? Would you find such PR reasonable for all 3 modules in app folder of Angular template (browser, server, shared)?

@MarkPieszak
Copy link
Contributor

If we could sync on the naming convention that would be ideal! 👍
Also having app.module be an NgModule itself (that browser & server import inside their imports[] would be ideal as well!

@SteveSandersonMS
Copy link
Member

Good plan. Done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants