Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Update to Angular2 Final #257

Closed
doczoidberg opened this issue Aug 12, 2016 · 31 comments
Closed

Update to Angular2 Final #257

doczoidberg opened this issue Aug 12, 2016 · 31 comments

Comments

@doczoidberg
Copy link

please support the latest release.

@danjford
Copy link

They'll probably have to wait for Angular2-universal to update as well as there are breaking changes with Angular2 RC5. Here is their RC issue.

@MarkPieszak
Copy link
Contributor

Yes it's still a work in progress, the changes created quite a ripple effect in Universal. It's a top priority though!

@MarkPieszak
Copy link
Contributor

I'll update and setup a PR in the next few days once everything is implemented / tested and published. Still need to iron out a few kinks, you can track PR angular/universal#524 if you'd like. Sorry for the delay!

@doczoidberg
Copy link
Author

RC6 is around the corner. maybe rc5 should be skipped?

@MarkPieszak
Copy link
Contributor

MarkPieszak commented Sep 1, 2016

Rc6 shipped last night, I'll update it to that when we figure everything out. :) shouldn't be long this time. Assuming it works with everything ;)

@lydemann
Copy link

lydemann commented Sep 5, 2016

@MarkPieszak What is the status on the rc6 update?

@MarkPieszak
Copy link
Contributor

MarkPieszak commented Sep 7, 2016

There are still a few outstanding issues we're facing before being able to publish the rc5/6 version of Universal (which will set us up to be prepared for the 1.0 release which is coming shortly as well (but it has no breaking changes thank god!)

The moment we publish Universal I'll refactor and update :)

You can live-track the things remaining here if you'd like:
angular/universal#511 (comment)

@SteveSandersonMS SteveSandersonMS changed the title Update to Angular2 RC5 Update to Angular2 RC6 Sep 9, 2016
@MarkPieszak
Copy link
Contributor

MarkPieszak commented Sep 13, 2016

@SteveSandersonMS
So we finally have things more fine tuned and I'll update to rc7 by Friday! 😀

@doczoidberg doczoidberg changed the title Update to Angular2 RC6 Update to Angular2 Final Sep 15, 2016
@vandensd
Copy link

Looking forward to the updates! Will the yo Generator update as well with all the goodies?

@MarkPieszak
Copy link
Contributor

Sure will, Steve's generator uses the templates inside the repo itself, so it will all be there :)

@mikelunn
Copy link

Now that Angular 2 finally officially released yesterday, i'm really looking forward update. The whole build pipeline with these next generation javascript frameworks are ridiculously complex. I love that this project template gives you a way to hit the ground running.

@hheexx
Copy link

hheexx commented Sep 16, 2016

Aungular-universal was also updated yesterday.
No show stoppers for updating templates now.

@MarkPieszak
Copy link
Contributor

Working on it now :) @hheexx
There might be some issues (from a Universal point of view) why I was waiting until we ironed out all of the kinks. But if anything Universal-related shows up, you can open up an issue at: https://github.com/angular/universal/issues or let me know here so I can take a look!

@MJomaa
Copy link

MJomaa commented Sep 17, 2016

@MarkPieszak Should one wait until it is updated or can I use the template now and update the missing parts manually?

@MarkPieszak
Copy link
Contributor

I'd say wait, I've had some delays since the changes we had to make in Universal were drastic but feel like I should have this finished up today, then we just need Steve to take a look and make sure everything checks out.

If you're just working on the Angular components themselves, or REST API, I'm sure you could get going and copy over most of that to a newer project template without any problems!

Trying to clean up the typescript 2 PR as well.

@MJomaa
Copy link

MJomaa commented Sep 17, 2016

@MarkPieszak Thank your for your response, I appreciate it.
The REST API is finished, so I will wait. Don't rush it :)

@MarkPieszak
Copy link
Contributor

MarkPieszak commented Sep 17, 2016

@MJomaa @hheexx @lydemeister @doczoidberg

I just posted the PR (#319) to upgrade to Angular 2.0.0, Universal 2.0.7, Preboot 4., and TypeScript 2.0 (which I needed to be able to include universal 2..)

This includes the NgModules, separate ones for both Client & Server, and is connected with the latest Universal API and updates.

Let me know here or create an issue under (https://github.com/angular/universal-starter/issues) if anything Universal-related comes up! There were major changes there, so something is bound to creep up.

The other projects will be upgraded to TS2.0 in the other PR, #258 when it's finished. (ReactReduxSpa was using outdated tsd files)

@vandensd They will be in the generator etc once Steve gets a chance to review & accept everything / publish it.

@vandensd
Copy link

Thanks for the update @MarkPieszak. I'm in no hurry but monitoring when everything is up to date. I'm actually still on RC2 for my stuff since I decided to hold when things were in flux. The template has been a great benefit to have and keep up the good work!

@ptk86
Copy link

ptk86 commented Sep 21, 2016

Is the aspnetcore-spa generator updated to Angular2 1.0? I reinstalled it and it still produces Angular 2 2.0.0-rc.4. Could you help?

@SteveSandersonMS
Copy link
Member

Now done :)

@ptk86 - It is updated and published to NPM as of about 30 minutes ago. You can update your generator by running npm install -g generator-aspnetcore-spa.

@doczoidberg
Copy link
Author

thanks for your great work!

@tanwarsatya
Copy link

tanwarsatya commented Sep 21, 2016

Not sure if someone tried the latest NPM or not. With all the defaults and even running webpack commands manually, when trying to run the application using VS it's not working.

Also it would be great if somebody can explain how the template is working( what all parts it has and the reason ) for newbies. Otherwise this all looks black box to someone who is coming from Asp.Net background.

This is a good example of explanation.

https://github.com/damienbod/Angular2WebpackVisualStudio

@mikelunn
Copy link

mikelunn commented Sep 21, 2016

@tanwarsatya This blog post has some good information about what the repository has to offer:
angular2-react-knockout-apps-on-aspnet-core

Make sure you first have the following installed
npm install -g yo generator-aspnetcore-spa
npm install -g webpack
Then create a new directory
cd some-empty-directory
Then run the following to create the project in the new folder
yo aspnetcore-spa
Then run this command to serve the app
dotnet run

Also, make sure you have the latest DotNetCore 1.0.1. I had 1.0.0, and when running dotnet run I received warning messages that it was required to have 1.0.1 installed.

@MJomaa
Copy link

MJomaa commented Sep 23, 2016

@tanwarsatya

Make sure to have Node 4.x installed, because else to-string loader will break.
Update Node simply with the Windows installer: https://nodejs.org/en/download/
And make sure to call webpack atleast once before dotnet run.

@vandensd
Copy link

@SteveSanderson

Performed a generator install a few days ago without a hitch.
Now today when an NPM install occurs on a new generator run (clean directory) core-js no longer comes down... in addition to a few other discrepancies in node_modules.

Problem is in Visual Studio Intellisense is not recognizing 'require' and 'Promise'. I believe core-js was filling this void.

@colltoaction
Copy link

I think it's actually @types/node, but check for yourself :)

On Fri, Sep 30, 2016, 00:51 Steve notifications@github.com wrote:

@SteveSanderson https://github.com/SteveSanderson

Performed a generator install a few days ago without a hitch.
Now today when an NPM install occurs on a new generator run (clean
directory) core-js no longer comes down... in addition to a few other
discrepancies in node_modules.

Problem is in Visual Studio Intellisense is not recognizing 'require' and
'Promise'. I believe core-js was filling this void.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#257 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9HgltgeLyq51hc-CS4pfuiDyy7M2ks5qvIddgaJpZM4JjHcg
.

@vandensd
Copy link

@tinchou
Agree this is the correct typings file and maybe core-js is not the factor...

However, VS (Enterprise 2015 Update 3)

Intellisense was non issue running generator a few days ago
Today it is

Interested in knowing what the solution might be

@colltoaction
Copy link

Maybe the update to Typescript 2 had something to to with it? I remember I
recently found an issue that pointed me to removing core-js completely. I
think it was angular universal, that brings its own polyfills.

I can look it up tomorrow if you don't find it.

On Fri, Sep 30, 2016, 01:26 Steve notifications@github.com wrote:

@tinchou https://github.com/tinchou
Agree this is the correct typings file and maybe core-js is not the
factor...

However, VS (Enterprise 2015 Update 3)

Intellisense was non issue running generator a few days ago
Today it is

Interested in knowing what the solution might be


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#257 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABeg9CVtWvUA-KpEOz7MibMJYpg9A_3iks5qvI9ogaJpZM4JjHcg
.

@vandensd
Copy link

vandensd commented Sep 30, 2016

@tinchou

Any help would be appreciated. I'm finding node, npm, day to day versioning and dependency changes, etc. hard to deal with when all I want is something that works out of the box...

As long as I don't update specific packages, I can roll with the node_modules installed a few days ago. So no rush except I'm sure others will run into issues like I am and a solution somewhere would be beneficial.

EDIT:

I'm using Node 4.x as advised but noticing @types is targeting 6.x?? Unless I'm misunderstanding.

@hheexx
Copy link

hheexx commented Sep 30, 2016

I had the same problem and solved it by moving tsconfig from ClientApp to root.

@MarkPieszak
Copy link
Contributor

Yes actually Steve we need to move the ts config back to root, almost forgot it can't go "down" directories when looking for @types or anything, just like packagejson webpack, they all need to be in the root 😓

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests