Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Specifying the Node project directory with webpack dev middleware #262

Closed
mattwcole opened this issue Aug 14, 2016 · 1 comment
Closed

Comments

@mattwcole
Copy link

I would like to be able to specify the Node project path when using webpack dev middleware to allow Javascript apps to be included from any location e.g.

Host/
  project.json
  Startup.cs
  Program.cs
App/
  package.json
  webpack.config.js
  src/
  node_modules/

At the moment it can't be changed from the content route. I've made what look like the necessary changes in a fork, but ran into another issue packaging the library before I could try it out. Happy to create a pull request if this is deemed useful enough.

@SteveSandersonMS
Copy link
Member

This looks good to me!

It's now implemented (pretty much the same as in your fork). I'll publish updated NuGet packages soon.

geirsagberg added a commit to geirsagberg/JavaScriptServices that referenced this issue Aug 17, 2016
* upstream/dev:
  Add ability to configure environment variables for Node instances, plus auto-populate NODE_ENV based on IHostingEnvironment when possible. Fixes aspnet#230
  Rename PrimeCache to PrimeCacheAsync (keeping older name as obsolete overload). Fixes aspnet#246.
  Prerenderer now passes original (unescaped) URL to Node - fixes aspnet#250
  In WebpackDevMiddleware, allow configuration of ProjectPath (implements aspnet#262)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants