Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

ts-loader / webpack 2 #785

Closed
johnnyreilly opened this issue Mar 23, 2017 · 2 comments
Closed

ts-loader / webpack 2 #785

johnnyreilly opened this issue Mar 23, 2017 · 2 comments

Comments

@johnnyreilly
Copy link

Hello!

I'm one of the maintainers of ts-loader. Listening to the live asp net show I realised you're using it in your templates. (Super cool BTW!)

There's 2 observations I'd make:

  1. At present you're using the 0.8^ version of ts-loader. I'd probably advise switching to the 1.x version if you're targeting webpack 1. The "breaking changes" version change was only really about dropping official support for node 0.12 (which has now been end of lifed). I'd be happy to submit a PR to do this if you'd like?

  2. webpack 2 has now been released (around Christmas time). It might be good to move to using webpack 2 in the templates. ts-loader moved to 2.x for webpack 2.

@SteveSandersonMS
Copy link
Member

Hey - thanks for your work on ts-loader!

I'm sorry to say we've moved most of the templates to awesome-typescript-loader, and will be moving the rest in due course. This is not because there was anything wrong with ts-loader, but simply because we measured awesome-typescript-loader to be significantly faster (about 2x). Maybe this is because of how it moves the type checking to a background thread so it can run in parallel with other aspects of the build - not sure of the exact mechanism. So, for those templates, we are already on Webpack 2, and will be migrating the others as we go.

Nonetheless, we did use ts-loader as the primary loader for quite a while, and it did a great job. So thanks again for your efforts with this!

@johnnyreilly
Copy link
Author

johnnyreilly commented Mar 23, 2017

Ah that's fair enough. Just so you're aware, the hope is that awesome-typescript-loader and ts-loader will join forces: s-panferov/awesome-typescript-loader#266. (And atl's background types checking mechanism will move into ts-loader.) That said I don't know when @s-panferov is planning for that to happen. (And of course it's always possible he could have changed his plans)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants