Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Moved FormsModule and HttpModule to app.modules.shared #1012

Closed
wants to merge 2 commits into from

Conversation

AmrineA
Copy link

@AmrineA AmrineA commented Jun 5, 2017

Moved FormsModule and HttpModule from from app.module.client to app.module.shared

@dnfclas
Copy link

dnfclas commented Jun 5, 2017

@AmrineA,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@SteveSandersonMS
Copy link
Member

Thanks for contributing this!

Based on @MarkPieszak's advice, I extended your PR a bit to make the shared module into a real @NgModule. This is now committed in f3b7103.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants