Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Added sample "jest" tests for counter reducer #509 #1041

Closed
wants to merge 3 commits into from

Conversation

rosieks
Copy link
Contributor

@rosieks rosieks commented Jun 17, 2017

This PR fills the gap between Angular and React-Redux template by adding test library and sample tests to the second one. #509

@dnfclas
Copy link

dnfclas commented Jun 17, 2017

@rosieks,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@SteveSandersonMS
Copy link
Member

Thanks for the suggestion!

These jest tests are not really equivalent to the karma tests in the Angular project, because the karma ones are testing at a UI level by automating the browser, whereas these jest tests are purely unit tests that don't describe the UI at all.

If we were to add sample tests to the Redux project, I think we'd want to add higher-level UI tests for equivalence. But that would still only be if those tests and its setup/config were all simple enough to be easily understood by a total newcomer.

Is that OK? Do you mind if I close this PR?

@rosieks
Copy link
Contributor Author

rosieks commented Jun 19, 2017

That make sense.

@rosieks rosieks closed this Jun 19, 2017
@SteveSandersonMS
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants