This repository was archived by the owner on Apr 8, 2020. It is now read-only.
redux template: automatically infer FetchData's new props type #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed
the
|
Thanks for submitting this PR! As it happens, the next version of the React-Redux template will be based around create-react-app output and this change won't be applicable to it (nor will the original issue). I'll close this because it doesn't apply to the newer template. Hope that's OK! |
|
That is nice to hear! |
This was referenced Sep 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After being connected to redux's store the props type isn't the same anymore since
WeatherForecastsStategets filled by the store.The template worked because when using the
FetchDatacomponent within theRoutecomponent it seems like its type doesn't get checked accurately. However using the component as<FetchData ... />generates an error since the properties ofWeatherForecastsStatewere seemingly missing.The type definition of redux's
connecthas been built in such a way, that the new props type gets automatically infered.