Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Update peerDependency to support webpack 3 #1559

Closed
wants to merge 1 commit into from

Conversation

jafin
Copy link

@jafin jafin commented Mar 2, 2018

Update peerDependency to support webpack 3.

  • This is only to remove the npm peer dep warning.
  • Reports of various people already running 3.x are listed in.

Addresses #1361

Update peerDependency to support webpack 3.
Reports of various people already running 3.x are listed in #1361.
This is only to remove the npm peer dep warning.
The issue with webpack 3 was fixed in aspnet-webpack, but this poor soul didn't get a bump.
@GeekyMonkey
Copy link

Why stop there. Webpack 4 is released now.

@jafin
Copy link
Author

jafin commented Mar 4, 2018

@GeekyMonkey #1361 Issue was for Webpack3. Mayby you could open an issue for Webpack 4 and PR. We don't have Webpack 4 here so I wouldn't be able to test sorry.

@SteveSandersonMS
Copy link
Member

Fixed with #1606. Thanks for contributing, @jafin!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants