Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Upgraded to typings from tsd. Moved URL workaround and load it with typings #179

Closed
wants to merge 2 commits into from
Closed

Upgraded to typings from tsd. Moved URL workaround and load it with typings #179

wants to merge 2 commits into from

Conversation

anwalkers
Copy link

Upgraded to typings from tsd. You will need to install typings globally

npm install -g typings

@dnfclas
Copy link

dnfclas commented Jul 13, 2016

Hi @anwalkers, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Jul 13, 2016

@anwalkers, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Jul 18, 2016

Thanks @anwalkers for submitting this! It's definitely great to keep the templates on an up-to-date technology stack.

A while ago in #53, @MarkPieszak and I were planning to update to Typings, but decided to put it on hold when the TypeScript team announced that with TypeScript v2.0, they would have native support for acquiring .d.ts files from NPM, so it will no longer be necessary to use either TSD or Typings for this in the templates.

I don't know how soon TypeScript 2.0 is going to ship, but I'm guessing it must be pretty much imminent - the beta has been out for a long time, and the roadmap planning has already moved on to 2.1.

Given the likelihood of a TS 2.0 release soon, and that we'll update to use its native support for acquiring .d.ts files at that time, would you agree it might be better to minimise the amount of churn by sticking with tsd until then? I don't think it will be hugely beneficial to encourage a change to this for what might be just a few days or weeks - any time spent tracking down new issues or incompatibilities would be obsolete very soon, and could better be spent enhancing other features.

What do you think? Would it be OK to wait until TS 2.0 ships? Obviously for your own project you've already put in Typings support so it isn't going to affect you, but I suspect that for others, having a simpler story about moving to native TS 2.0 support when available could be a preferable arrangement.

@MarkPieszak
Copy link
Contributor

@SteveSandersonMS So I just updated the Universal project to use the new @types, but it's up to you whether you think we should wait for the official release or use typescript@beta and start using it already. It's definitely really nice to just have the package.json contain everything now, love 2.0 so far! Nice job by the TS team :)

@anwalkers
Copy link
Author

Sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants