Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Call OnStarting before verifying response length #1303

Closed
cesarblum opened this issue Jan 10, 2017 · 1 comment
Closed

Call OnStarting before verifying response length #1303

cesarblum opened this issue Jan 10, 2017 · 1 comment
Assignees
@cesarblum
Labels
3 - Done bug patch-approved
Milestone
1.1.1

Comments

@cesarblum
Copy link
Contributor

Original issue: #1289
@cesarblum cesarblum added this to the 1.1.1 milestone Jan 10, 2017
@cesarblum cesarblum self-assigned this Jan 10, 2017
@cesarblum cesarblum mentioned this issue Jan 10, 2017
Closed
@Eilon
Copy link
Member

Eilon commented Jan 19, 2017

This patch bug is approved. Please use the normal code review process w/ a PR and make sure the fix is in the correct branch, then close the bug and mark it as done.

cesarblum pushed a commit that referenced this issue Jan 25, 2017
Call OnStarting before verifying response length (#1303).
3dd46cf 
- Also don't close connection when Content-Length set but no bytes written.
@cesarblum cesarblum mentioned this issue Jan 25, 2017
Merged
cesarblum pushed a commit that referenced this issue Jan 29, 2017
Call OnStarting before verifying response length (#1303).
c11aedd 
- Also don't close connection when Content-Length set but no bytes written.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cesarblum cesarblum

Labels
3 - Done bug patch-approved
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
2 participants
@Eilon @cesarblum