-
Notifications
You must be signed in to change notification settings - Fork 527
Switch default transport to sockets #2360
Comments
@halter73 shouldn't the announcement prefer |
@Suchiman Your edit is correct. That's the main thing that makes the change breaking. |
Do the managed sockets have similar performance compared to libuv? |
@ondravondra yes that was the prerequisite for the switch and why preview1 still ships with libuv. I think it might even be.a little faster already |
@halter73 this is done, can you close this issue? |
Just a heads up, the announcement has the tag |
@nickalbrecht thanks for spotting that. I updated the milestone on the announcement. |
Couple of months ago, it was indicated that performance regressed when switching to sockets #2220. Are there any before/after performance measurements to bring about concreteness to the mix? |
@kasper3 EDIT: Ah i think i see my mistake. Sockets PlainText Platform is a bit faster than LibUv PlainText Platform and both are ~1.5 million RPS faster than Kestrel LibUv PlainText which is a bit faster than Sockets PlainText. Interesting that only the Platform Level Benchmark of Sockets beats LibUv. |
Currently, it is our goal by 2.1.0 to make sockets the default transport. We made the switch in early builds of 2.1.0 but reverted that for preview1 (#2220) due to performance issues.
Motivations:
/cc @halter73 @davidfowl @muratg
The text was updated successfully, but these errors were encountered: