Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Remove package dependency from Kestrel to Kestrel.Transport.Libuv #2361

Closed
natemcmaster opened this issue Mar 5, 2018 · 3 comments
Closed

Comments

@natemcmaster
Copy link
Contributor

natemcmaster commented Mar 5, 2018

Related issue: #2360

Remove the package dependency from Microsoft.AspNetCore.Server.Kestrel to Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.

This will break those who only depend on the Microsoft.AspNetCore.Server.Kestrel package and who call WebHostBuilderLibuvExtensions.UseLibuv(). These users can fix their projects by re-adding the dependency to libuv.

<PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv" Version="2.1.0" />

To minimize the number of 2.0 users that this will break, we should keep Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv in the dependency graph of Microsoft.AspNetCore.All.

Design meeting notes from March 2, 2018

/cc @halter73 @davidfowl @muratg

@muratg
Copy link
Contributor

muratg commented Mar 6, 2018

@natemcmaster Libuv package is directly in All I assume? So if you're using the metapackage, you wouldn't be broken? (As long as we don't remove it)

@natemcmaster
Copy link
Contributor Author

Correct you won't be broken. No, .All doesn't directly reference "Libuv", but it does directly reference "Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv", so you still get the Libuv package transitively in .All

@muratg muratg added this to the 2.1.0-preview2 milestone Mar 6, 2018
@halter73
Copy link
Member

Fixed by #2392 and aspnet/Universe#959

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants