Allocate less in GetIPEndPoint #1004

pakrym · 2016-07-21T17:23:25Z

Trim 2 byte arrays creation for IPv6 addresses.

pakrym · 2016-07-21T17:23:36Z

cc @davidfowl @halter73 @CesarBS

pakrym · 2016-07-21T18:38:26Z

This happens per connection, so might not have hight impact.

halter73 · 2016-07-21T18:52:34Z

cesarblum · 2016-07-21T18:53:55Z

src/Microsoft.AspNetCore.Server.Kestrel/Internal/Networking/SockAddr.cs

-                {
-                    bytes[i] = bytes1[i];
-                    bytes[i + 8] = bytes2[i];
+                fixed (byte* b = bytes) {


nit: { in new line

cesarblum · 2016-07-21T18:57:00Z

🚢

dnfclas added the cla-already-signed label Jul 21, 2016

cesarblum reviewed Jul 21, 2016
View reviewed changes

Allocate less in GetIPEndPoint

331fe94

pakrym force-pushed the pakrym/less-aloc branch from 87b2e3d to 331fe94 Compare July 21, 2016 18:55

pakrym merged commit 7b7e288 into dev Jul 21, 2016

cesarblum deleted the pakrym/less-aloc branch July 21, 2016 19:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allocate less in GetIPEndPoint #1004

Allocate less in GetIPEndPoint #1004

pakrym commented Jul 21, 2016

pakrym commented Jul 21, 2016

pakrym commented Jul 21, 2016 •

edited

Loading

halter73 commented Jul 21, 2016

cesarblum Jul 21, 2016

cesarblum commented Jul 21, 2016

Allocate less in GetIPEndPoint #1004

Allocate less in GetIPEndPoint #1004

Conversation

pakrym commented Jul 21, 2016

pakrym commented Jul 21, 2016

pakrym commented Jul 21, 2016 • edited Loading

halter73 commented Jul 21, 2016

cesarblum Jul 21, 2016

Choose a reason for hiding this comment

cesarblum commented Jul 21, 2016

pakrym commented Jul 21, 2016 •

edited

Loading