Use Buffer.MemoryCopy when available #1036
Conversation
|
Have you checked the benchmarks I did for .NET 4.6 RyuJIT 64-bit, not sure |
|
Well its currently using BlockCopy so MemoryCopy is currently better 😄 And it looks like it will improve |
benaadams
force-pushed
the
block-copy
branch
3 times, most recently
from
fb5bd9c to
152af3d
Compare
|
Updated #1002 with further test failure info |
| return Consume(count, out actual); | ||
| } | ||
|
|
||
| Debug.Assert(count + offset <= array.Length); |
There was a problem hiding this comment.
Maybe should change it to actual throw?
There was a problem hiding this comment.
Also get the test the right way round XD
|
I'd hold on this - movement in coreclr on BlockCopy dotnet/coreclr#7198 |
|
@benaadams Any updates on this? dotnet/coreclr#7198 was merged almost a month ago. |
|
@CesarBS that change is in post 1.1.0 😞 Could take this now and add issue to remeasure post 1.1.0? |
|
@benaadams Since this missed the 1.1 train and dotnet/coreclr#7198 is merged, should we close this? |
|
Yeah, think so - landscape has changed. Might be worth a revalidation at some point; but don't think its worth keeping this PR open |
MemoryCopy has improved a lot (and is faster than BlockCopy) dotnet/coreclr#6627
And is undergoing further improvements dotnet/coreclr#6638