Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

Remove use of Dangerous* Span APIs and use MemoryMarshal instead #2222

Closed
wants to merge 1 commit into from
Closed

Remove use of Dangerous* Span APIs and use MemoryMarshal instead #2222

wants to merge 1 commit into from

Conversation

ahsonkhan
Copy link
Contributor

@ahsonkhan ahsonkhan commented Dec 16, 2017 •
edited
Loading

See https://github.com/dotnet/corefx/issues/25412#issuecomment-352176634

Depends on a package update to aspnet/Universe to go through - aspnet/Universe#717

/home/travis/build/aspnet/KestrelHttpServer/benchmarks/Kestrel.Performance/Kestrel.Performance.csproj : error NU1102: Unable to find package System.Security.Cryptography.Cng with version (>= 4.5.0-preview1-26016-05) [/home/travis/build/aspnet/KestrelHttpServer/KestrelHttpServer.sln]

  • SignalR doesn't use DangerousGetPinnableReference or DangerousTryGetArray (these APIs will be removed/changed).
  • Kestrel doesn't use DangerousTryGetArray
  • I couldn't find any other aspnet repo that relied on these two APIs.

cc @pakrym, @davidfowl, @BrennanConroy, @KrzysztofCwalina, @natemcmaster, @jkotas, @joshfree

@ahsonkhan ahsonkhan mentioned this pull request Dec 16, 2017
Closed
@pakrym pakrym self-assigned this Dec 19, 2017
@pakrym pakrym mentioned this pull request Dec 19, 2017
Merged
@pakrym
Copy link
Contributor

pakrym commented Dec 19, 2017

Closing in favor of #2228

@pakrym pakrym closed this Dec 19, 2017
@ahsonkhan ahsonkhan deleted the RemoveUseOfDangerous branch December 21, 2017 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pakrym pakrym

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsonkhan @pakrym