Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Add retries when downloading nuget.exe #214

Closed
mikeharder opened this issue Mar 24, 2017 · 3 comments
Closed

Add retries when downloading nuget.exe #214

mikeharder opened this issue Mar 24, 2017 · 3 comments
Assignees
Labels

Comments

@mikeharder
Copy link
Contributor

KoreBuild should add retries when downloading nuget.exe to prevent build breaks.

https://github.com/aspnet/KoreBuild/blob/dev/build/KoreBuild.ps1#L94-L99
https://github.com/aspnet/KoreBuild/blob/dev/build/KoreBuild.sh#L147-L151

@pranavkm
Copy link
Contributor

We can probably remove the one from KoreBuild.sh.

@mikeharder mikeharder self-assigned this Mar 25, 2017
@Eilon Eilon added this to the 2.0.0-preview1 milestone Mar 26, 2017
@Eilon Eilon added the task label Mar 26, 2017
@mikeharder
Copy link
Contributor Author

Another failure: http://aspnetci/viewLog.html?buildId=206695&tab=buildResultsDiv&buildTypeId=XPlat_Windows_Win10Universe

  Invoke-WebRequest : Unable to connect to the remote server
  At C:\BuildAgent\work\2b0c8ce712895332\.r\KestrelHttpServer\.build\KoreBuild.ps1:101 char:5
  +     Invoke-WebRequest "https://dist.nuget.org/win-x86-commandline/v4. ...
  +     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:HttpWebRequest) [Invoke-WebRequest], WebExc 
     eption
      + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShell.Commands.InvokeWebRequestCommand
   
C:\BuildAgent\work\2b0c8ce712895332\build\RepositoryBuild.targets(60,5): error MSB3073: The command "./build.cmd /t:Verify /p:BuildNumber=24579 /p:Configuration=Release" exited with code 1.

natemcmaster pushed a commit that referenced this issue Apr 27, 2017
- No longer download NuGet.exe. Fixes #214
- Don't generate global.json
- Don't suppress color output on CI
natemcmaster pushed a commit that referenced this issue Apr 27, 2017
- No longer download NuGet.exe. Fixes #214
- Don't generate global.json
- Don't suppress color output on CI. Fixes #193
- Add comments to template file. Fixes #222
@mikeharder mikeharder removed their assignment Apr 29, 2017
natemcmaster pushed a commit that referenced this issue May 1, 2017
- No longer download NuGet.exe. Fixes #214
- Don't generate global.json
- Don't suppress color output on CI. Fixes #193
- Add comments to template file. Fixes #222
natemcmaster added a commit that referenced this issue May 1, 2017
- No longer download NuGet.exe. Fixes #214
- Don't generate global.json
- Add comments to template file. Fixes #222
@natemcmaster natemcmaster self-assigned this May 1, 2017
@natemcmaster
Copy link
Contributor

Closed by removing the NuGet.exe download. As far as we could tell, none of our build scripts actually use this anymore now that we have dotnet nuget.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants