This repository was archived by the owner on May 21, 2019. It is now read-only.
Use ** rather than * for globbing #109
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into an issue when building https://github.com/aspnet/JavaScriptServices where the samples were in a lower subdirectory. Since the glob `samples/*/project.json` would only match projects directly below `samples`, the projects were not being built. Using `** ` instead matches all `project.json` in all subdirectories.
|
Hi @geirsagberg, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
Pretty sure we did this on purpose, it avoids building things like /samples/HelloSample/bin/Debug/net451/project.json |
|
We shouldn't change our default but having it be configurable is ok |
|
Gotcha. I'll close the PR for now and re-open it if I can figure out how to make it configurable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when building https://github.com/aspnet/JavaScriptServices where the samples were in a lower subdirectory. Since the glob
samples/*/project.jsonwould only match projects directly belowsamples, the projects were not being built. Using**instead matches allproject.jsonin all subdirectories.