-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for "fileMappings" #756
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7bcab36
Add fileMappings to the DTOs
jimmylewis 639bf3e
Use FileMappings when calculating the GoalState
jimmylewis 1b30db9
Schema changes to support fileMappings
jimmylewis 1c920cb
Add "3.0" manifest version to SupportedVersions
jimmylewis 407ab41
PR feedback - XML docs on mock type
jimmylewis 9697b44
Merge branch 'main' into fileMapping
phil-allen-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
#nullable enable | ||
|
||
using System.Collections.Generic; | ||
|
||
namespace Microsoft.Web.LibraryManager.Contracts | ||
{ | ||
/// <summary> | ||
/// | ||
/// </summary> | ||
public class FileMapping | ||
{ | ||
/// <summary> | ||
/// Root path within the library content for this file mapping entry. | ||
/// </summary> | ||
public string? Root { get; set; } | ||
|
||
/// <summary> | ||
/// Destination folder within the project. | ||
/// </summary> | ||
public string? Destination { get; set; } | ||
|
||
/// <summary> | ||
/// The file patterns to match for this mapping, relative to <see cref="Root"/>. Accepts glob patterns. | ||
/// </summary> | ||
public IReadOnlyList<string>? Files { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Collections.Generic; | ||
using Newtonsoft.Json; | ||
|
||
#nullable enable | ||
|
||
namespace Microsoft.Web.LibraryManager.Json | ||
{ | ||
internal class FileMapping | ||
{ | ||
[JsonProperty(ManifestConstants.Root)] | ||
public string? Root { get; set; } | ||
|
||
[JsonProperty(ManifestConstants.Destination)] | ||
public string? Destination { get; set; } | ||
|
||
[JsonProperty(ManifestConstants.Files)] | ||
public IReadOnlyList<string>? Files { get; set; } | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a case for v1 manifests where (if they followed the schema) they could encounter this error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v1 schema was declared such that either a defaultDestination must be set, or every library must set a destination. But it got too complicated to be oneOf (defaultDestination, or every library sets a destination, or (every library without fileMappings sets a destination or every fileMapping under a library without a destination includes a fileMapping destination)).