This repository has been archived by the owner on Nov 29, 2018. It is now read-only.
Improve usability of the request localization middleware #164 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if the issue #127 should take place here or will be ignored |
| { | ||
| if (value == null) | ||
| { | ||
| throw new ArgumentNullException(); |
There was a problem hiding this comment.
Should have the name of the property in the exception yeah?
There was a problem hiding this comment.
Yeah I actually wasn't sure what name to use here, but property name makes sense.
There was a problem hiding this comment.
This should be nameof(value). That is the name of the parameter.
|
@hishamco that will be separate |
|
|
DamianEdwards
force-pushed
the
damianedwards/bug-164
branch
from
0d6ca2a to
008597f
Compare
- Remove the defaultRequestCulture parameter from IApplicationBuilder.UseRequestLocalization and make it a property on RequestLocalizationOptions instead - Have just a single overload for IApplicationBuilder.UseRequestLocalization that takes the options - #164
DamianEdwards
force-pushed
the
damianedwards/bug-164
branch
from
008597f to
0b013ae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#164
Fixed up some out of date doc comments too.
@rynowak @ryanbrandenburg @Eilon