Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Fix exception messages for Azure App Services logger to say "must" instead of "should" #508

@Eilon

Description

@Eilon

Here:

if (batchSizeLimit <= 0)
{
throw new ArgumentOutOfRangeException(nameof(batchSizeLimit), $"{nameof(batchSizeLimit)} should be a positive number.");
}
if (period <= TimeSpan.Zero)
{
throw new ArgumentOutOfRangeException(nameof(period), $"{nameof(period)} should be longer than zero.");
}

And here:

if (fileSizeLimit <= 0)
{
throw new ArgumentOutOfRangeException(nameof(fileSizeLimit), $"{nameof(fileSizeLimit)} should be positive.");
}
if (retainedFileCountLimit <= 0)
{
throw new ArgumentOutOfRangeException(nameof(retainedFileCountLimit), $"{nameof(retainedFileCountLimit)} should be positive.");
}

We must change the word should to must.

See https://www.ietf.org/rfc/rfc2119.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions