This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Fix EventLogger in .NET 4.5.2 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
force-pushed
the
brecon/event_log
branch
from
7d1448e to
f18466d
Compare
BrennanConroy
changed the title
|
Looks good, but I would add a comment explaining why SetFilterSpec is not immediately called on logging providers when EventSource.SetFilterSpec is called |
|
Good point |
|
Some explanation would be good in the PR description, what was wrong and what was fixed |
|
@davidfowl Added some description |
|
🆙 📅 |
|
Ping |
|
|
| } | ||
|
|
||
| [NonEvent] | ||
| internal void VerifyLevel() |
There was a problem hiding this comment.
Any concurrency concerns? Can this be called in parallel?
|
🆙 📅 |
| @@ -37,6 +37,7 @@ public EventSourceLoggerProvider(LoggingEventSource eventSource, EventSourceLogg | |||
| /// </summary> | |||
| public ILogger CreateLogger(string categoryName) | |||
| { | |||
| _eventSource.VerifyLevel(); | |||
There was a problem hiding this comment.
Add a comment wherever you call VerifyLevel() (which is the wrong name)
BrennanConroy
force-pushed
the
brecon/event_log
branch
from
1783842 to
f61abfd
Compare
BrennanConroy
force-pushed
the
brecon/event_log
branch
from
f61abfd to
62265c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
OnEventCommandcallback changed between.NET 4.5.2and.NET 4.6. In the latter the internalEventSourcelevel has changed before calling theOnEventCommandcallback which was behavior we relied on to set the loggers level. Because it isn't set before the callback in.NET 4.5.2we delay the original behavior of the callback until a time after the Event change occurs.#328