This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Harden log formatters to handle null formats, null arguments, and null arrays of arguments #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,6 +115,8 @@ private static int FindIndexOf(string format, char ch, int startIndex, int endIn | |||
| return findIndex == -1 ? endIndex : findIndex; | |||
| } | |||
|
|
|||
| private static readonly object[] EmptyArray = new object[0]; | |||
There was a problem hiding this comment.
Move this to the top of the files with the other fields.
There was a problem hiding this comment.
Why not just Array.Empty<object>() ?
There was a problem hiding this comment.
btw, is the s_ variable name prefix for static/const privates s_varName a convention we do on this team?
|
looks good to me. Have someone more familiar with this code sign off on this though. |
|
|
| @@ -20,6 +20,7 @@ public class LogValuesFormatter | |||
|
|
|||
| public string OriginalFormat { get; private set; } | |||
| public List<string> ValueNames => _valueNames; | |||
| private const string NullValue = "(null)"; | |||
There was a problem hiding this comment.
nit: move to top of class, or below existing private members.
There was a problem hiding this comment.
While you're at it, you could move OriginalFormat and ValueNames after the ctor
natemcmaster
force-pushed
the
namc/null
branch
2 times, most recently
from
c5e1bdb to
c6ac6df
Compare
natemcmaster
force-pushed
the
namc/null
branch
from
c6ac6df to
db0ba84
Compare
natemcmaster
pushed a commit
to aspnet/Mvc
that referenced
this pull request
Aug 26, 2016
natemcmaster
pushed a commit
to aspnet/Identity
that referenced
this pull request
Aug 26, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #422
cc @muratg @BrennanConroy