This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Initial pass at Metrics support in ILogger #709
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym
reviewed
Sep 19, 2017
| @@ -136,6 +139,21 @@ public IDisposable BeginScope<TState>(TState state) | |||
| return scope; | |||
| } | |||
|
|
|||
| public IMetric DefineMetric(string name) | |||
| { | |||
| if (!_metrics.TryGetValue(name, out var metric)) | |||
There was a problem hiding this comment.
Is dictionary safe for multi thread read during the write?
There was a problem hiding this comment.
I'm honestly not sure. I was having the same concern and thinking I should just use ConcurrentDictionary
pakrym
reviewed
Sep 20, 2017
| @@ -13,6 +13,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" /> | |||
| <PackageReference Include="Microsoft.Extensions.Options" /> | |||
| <PackageReference Include="System.Collections.Immutable" /> | |||
There was a problem hiding this comment.
Not anymore, will remove
pakrym
reviewed
Sep 20, 2017
| _name = name; | ||
| } | ||
|
|
||
| public void RecordValue(double value) |
There was a problem hiding this comment.
As we discussed this implementation has to be optimized to update metrics array only when required.
pakrym
reviewed
Sep 20, 2017
| } | ||
| } | ||
|
|
||
| public void RecordValue<T>(double value, T properties) where T : IEnumerable<KeyValuePair<string, object>> |
There was a problem hiding this comment.
Test for this and TimeSpan extension method.
|
Closing this, we're going to look at using EventCounters for our metrics needs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #708. It's got some naive elements, like the way we handle filters (which involves some locking). I want to clean that up but wanted to get this into a PR first.