Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Microsoft.AspNetCore.All can be installed into net461 project without error #142

@analogrelay

Description

@analogrelay

Repro Steps:

  1. Create new .NET Console Core app
  2. Change target framework to net461
  3. Add reference to Microsoft.AspNetCore.All
  4. Restore

Expected behavior: Error of some kind

Actual behavior: It references the package "successfully" but silently fails to bring in any types.

We have a build\PublishWithAspNetCoreTargetManifest.targets file, which means NuGet thinks the package is supported by all frameworks (with a special targets file for netcoreapp2.0). We should put that file in build\netcoreapp2.0 so NuGet will see that there are no assets for any other framework.

Also, we need to verify that NuGet does actually disallow installing it in that circumstance. It's possible it won't disallow it, just won't reference the targets files. In that case, we could put a fallback targets file with an error message.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions