Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Add ConfigureAspNetCoreDefaults #118

Closed
wants to merge 9 commits into from
Closed

Add ConfigureAspNetCoreDefaults #118

wants to merge 9 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented May 17, 2017

Initial prototype of #117

  • New ConfigureAspNetCoreDefaults() that will add all of the IConfigureOptions for the default sections
  • Currently: Kestral/OIDC/Google/Facebook/Twitter/MSA/JwtBearer/Identity
  • Moved kestrel config under Microsoft:AspNetCore:Hosting

@dnfclas
Copy link

dnfclas commented May 17, 2017

@HaoK,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Copy link
Member

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @davidfowl @DamianEdwards

We need to think a bit more about which dependencies go where. We can't add too many deps to the mini-metapackage. But, if we add this to the All-metapackage, then it can't be used from .NET Framework apps/templates.

@HaoK
Copy link
Member Author

HaoK commented May 22, 2017

Updated using new options infrastructure. Should the kestrel setup move to Kestrel instead of living here like the rest of the default setup?

@HaoK HaoK changed the title [Prototype] Add ConfigureAspNetCoreDefaults Add ConfigureAspNetCoreDefaults May 22, 2017
@HaoK
Copy link
Member Author

HaoK commented May 22, 2017

@JunTaoLuo do you own MetaPackage? Who should review this change?

@HaoK
Copy link
Member Author

HaoK commented May 26, 2017

Merged without the kestrel changes which would break templates without the corresponding config update

@HaoK HaoK closed this May 26, 2017
@natemcmaster natemcmaster deleted the haok/options branch November 20, 2018 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants