PR cleanup

aspnet · Aug 25, 2016 · 5b2a912 · 5b2a912
1 parent 57e4c78
commit 5b2a912
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/EnumGroupAndName.cs b/src/Microsoft.AspNetCore.Mvc.Abstractions/ModelBinding/EnumGroupAndName.cs
@@ -33,6 +33,11 @@ public EnumGroupAndName(string group, string name)
             _nameFunc = () => name;
         }
 
+        /// <summary>
+        /// Initializes a new instance of the EnumGroupAndName structure.
+        /// </summary>
+        /// <param name="group">The group name.</param>
+        /// <param name="name">A function which returns the name. (Necessary for proper localization.)</param>
         public EnumGroupAndName(string group, Func<string> name)
         {
             if (group == null)

diff --git a/src/Microsoft.AspNetCore.Mvc.DataAnnotations/Internal/DataAnnotationsMetadataProvider.cs b/src/Microsoft.AspNetCore.Mvc.DataAnnotations/Internal/DataAnnotationsMetadataProvider.cs
@@ -168,8 +168,6 @@ public void CreateDisplayMetadata(DisplayMetadataProviderContext context)
 
                 displayMetadata.EnumGroupedDisplayNamesAndValues = groupedDisplayNamesAndValues;
                 displayMetadata.EnumNamesAndValues = namesAndValues;
-
-                //displayMetadata.EnumGroupedDisplayNamesAndValueFuncs = groupedDisplayNamesAndValueFuncs;
             }
 
             // HasNonDefaultEditFormat

diff --git a/...osoft.AspNetCore.Mvc.DataAnnotations.Test/Internal/DataAnnotationsMetadataProviderTest.cs b/...osoft.AspNetCore.Mvc.DataAnnotations.Test/Internal/DataAnnotationsMetadataProviderTest.cs
@@ -817,7 +817,6 @@ public void CreateDisplayMetadata_EnumGroupedDisplayNamesAndValues_IStringLocali
             }
 
             // Assert
-            // OrderBy is used because the order of the results may very depending on the platform / client.
             Assert.NotEqual(frenchEnumDisplay, englishEnumDisplay);
             Assert.Equal("LOC_Two fr-FR", frenchEnumDisplay);
             Assert.Equal("LOC_Two en-US", englishEnumDisplay);
@@ -853,7 +852,6 @@ public void CreateDisplayMetadata_EnumGroupedDisplayNamesAndValues_ResourceTypeL
             }
 
             // Assert
-            // OrderBy is used because the order of the results may very depending on the platform / client.
             Assert.NotEqual(frenchEnumDisplay, englishEnumDisplay);
             Assert.Equal("Type Three fr-FR", frenchEnumDisplay);
             Assert.Equal("Type Three en-US", englishEnumDisplay);