Find IDocumentProvider using a more-laborious process

- `Type.GetType(string)` requires an assembly-qualified name and we don't know the assembly nit: - reflect recent change to `dotnet-getdocument`'s `Resources.resx` file in its designer file
aspnet · Oct 11, 2018 · d2d253d · d2d253d
1 parent 5cd8697
commit d2d253d
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 3 deletions.
diff --git a/src/GetDocumentInsider/Commands/GetDocumentCommandWorker.cs b/src/GetDocumentInsider/Commands/GetDocumentCommandWorker.cs
@@ -56,7 +56,23 @@ public static bool TryProcess(GetDocumentCommandContext context, IServiceProvide
 
             try
             {
-                var serviceType = Type.GetType(serviceName, throwOnError: true);
+                Type serviceType = null;
+                foreach (var assembly in AppDomain.CurrentDomain.GetAssemblies())
+                {
+                    serviceType = assembly.GetType(serviceName, throwOnError: false);
+                    if (serviceType != null)
+                    {
+                        break;
+                    }
+                }
+
+                if (serviceType == null)
+                {
+                    // As part of the aspnet/Mvc#8425 fix, make this an error unless the file already exists.
+                    Reporter.WriteWarning(Resources.FormatServiceNotFound(serviceName));
+                    return true;
+                }
+
                 var method = serviceType.GetMethod(methodName, new[] { typeof(TextWriter), typeof(string) });
                 var service = services.GetRequiredService(serviceType);
 

diff --git a/src/GetDocumentInsider/Properties/Resources.Designer.cs b/src/GetDocumentInsider/Properties/Resources.Designer.cs
diff --git a/src/GetDocumentInsider/Resources.resx b/src/GetDocumentInsider/Resources.resx
@@ -162,4 +162,7 @@
   <data name="MissingEntryPoint" xml:space="preserve">
     <value>Assembly '{0}' does not contain an entry point.</value>
   </data>
+  <data name="ServiceNotFound" xml:space="preserve">
+    <value>Unable to find service type '{0}' in loaded assemblies.</value>
+  </data>
 </root>
diff --git a/src/dotnet-getdocument/Properties/Resources.Designer.cs b/src/dotnet-getdocument/Properties/Resources.Designer.cs