This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Tag Helpers: Remove type activation for the creation of TagHelpers #1303
Comments
NTaylorMullen
pushed a commit
that referenced
this issue
Oct 9, 2014
- We now rely on Activator.CreateInstance to instantiate TagHelpers. - Added test to validate throwing. - Removed existing tests that expected the constructor injection behavior. #1303
NTaylorMullen
pushed a commit
that referenced
this issue
Oct 9, 2014
- We now rely on Activator.CreateInstance to instantiate TagHelpers. - Added test to validate throwing. - Removed existing tests that expected the constructor injection behavior. #1303
NTaylorMullen
pushed a commit
that referenced
this issue
Oct 9, 2014
- We now new up TagHelper's, requiring them to have parameterless constructors. - Added test to validate throwing. - Removed existing tests that expected the constructor injection behavior. #1303
NTaylorMullen
pushed a commit
that referenced
this issue
Oct 9, 2014
- We now new up TagHelper's, requiring them to have parameterless constructors. - Added test to validate throwing. - Removed existing tests that expected the constructor injection behavior. #1303
NTaylorMullen
pushed a commit
that referenced
this issue
Oct 9, 2014
- We now new up TagHelper's, requiring them to have parameterless constructors. - Added test to validate throwing. - Removed existing tests that expected the constructor injection behavior. #1303
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After talks with @yishaigalatzer it turns out the activator is pretty heavy weight and not worth the investment in creating
TagHelpers. We should remove the current functionality of accepting dependencies in the constructor.The text was updated successfully, but these errors were encountered: