Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Remove disable buffering feature from our action result classes #4766

Closed
javiercn opened this issue May 27, 2016 · 1 comment
Closed

Remove disable buffering feature from our action result classes #4766

javiercn opened this issue May 27, 2016 · 1 comment
Assignees

Comments

@javiercn
Copy link
Member

See https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.Core/ContentResult.cs#L70
It's not implemented by any of our servers and we haven't figured out in detail how it would work, it doesn't hurt right now to have it, but it's a premature optimization. We can remove it at a later point

@lodejard
Copy link
Contributor

I actually does hurt to have it - see #4876. The action results should only disable buffering if it's necessary for them to function correctly, but it shouldn't be done as an optimization because it's counteracting the app dev's choice to add buffering middleware.

Calling flushasync on the response body when you don't need to fits into the same category.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants