Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Async resource filters' short circuited result getting executed more than once. #5175

Closed
kichalla opened this issue Aug 22, 2016 · 3 comments
Closed

Async resource filters' short circuited result getting executed more than once. #5175

kichalla opened this issue Aug 22, 2016 · 3 comments
Assignees
@kichalla
Labels
3 - Done bug
Milestone
1.1.0-preview1

Comments

@kichalla
Copy link
Member

This issue does not happen with sync filters.

Following PR (is a diff between 1.0 branch code) shows the potential changes that are required in ControllerActionInvoker:
#5174

@rynowak

This issue happens with latest dev branch too.
@kichalla kichalla added the bug label Aug 22, 2016
@rynowak
Copy link
Member

rynowak commented Aug 22, 2016

Does this happen in 1.0.0 or only in 1.1.0?

@kichalla
Copy link
Member Author

Does this happen in 1.0.0 or only in 1.1.0?

It happens in both.

@Eilon Eilon added this to the 1.1.0 milestone Aug 23, 2016
@Eilon
Copy link
Member

Eilon commented Aug 23, 2016

Not sure this meets the bar for a patch release because we're not aware of this being a broad problem. But if we do get hints of it being broader, we will reevaluate.

kichalla added a commit that referenced this issue Aug 23, 2016
@kichalla
[Fixes #5175] Async resource filters' short circuited result getting …
fa830ea 
…executed more than once.
kichalla added a commit that referenced this issue Aug 23, 2016
@kichalla
[Fixes #5175] Async resource filters' short circuited result getting …
db7f0bc 
…executed more than once.
kichalla added a commit that referenced this issue Aug 24, 2016
@kichalla
[Fixes #5175] Async resource filters' short circuited result getting …
4cfcb66 
…executed more than once.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done bug
Projects
None yet
Milestone
1.1.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @rynowak @kichalla