Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

PagedBufferedTextWriter does not flush synchronous data prior to writing data asynchronously to the underlying stream #5241

Closed
pranavkm opened this issue Sep 6, 2016 · 1 comment
Assignees

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Sep 6, 2016

PagedBufferedTextWriter works in two modes: in sync, it accumulates text in char buffers. In async it writes directly to the underlying stream. However it does not flush any of the buffered contents prior to doing this. All of it's async calls should flush buffered content prior to writing to the underlying writer.

@rynowak
Copy link
Member

rynowak commented Sep 6, 2016

This needs to be fixed because if you called WriteAsync(...).GetAwaiter().GetResult() in an IHtmlContent you would have out of order writing.

@danroth27 danroth27 added this to the 1.1.0 milestone Sep 7, 2016
@pranavkm pranavkm changed the title PagedBufferedTextWriter does not flush synchronous data prior to writing data return asynchronously to the underlying stream PagedBufferedTextWriter does not flush synchronous data prior to writing data asynchronously to the underlying stream Sep 8, 2016
pranavkm added a commit that referenced this issue Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants