Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

Create an analyzer to warn users not to decorate filters on page handler methods #7684

Closed
kichalla opened this issue Apr 19, 2018 · 2 comments
Closed

Create an analyzer to warn users not to decorate filters on page handler methods #7684

kichalla opened this issue Apr 19, 2018 · 2 comments
Assignees
@pranavkm
Labels
3 - Done cost: S Will take up to 2 days to complete enhancement PRI: 2 - Preferred Preferably should be handled during the milestone.
Milestone
2.2.0-preview1

Comments

@kichalla
Copy link
Member

Related discussion: #7674
@mkArtakMSFT mkArtakMSFT added this to the 2.2.0 milestone Apr 24, 2018
@mkArtakMSFT mkArtakMSFT modified the milestones: 2.2.0, 2.2.0-preview1 May 14, 2018
@mkArtakMSFT mkArtakMSFT added the PRI: 2 - Preferred Preferably should be handled during the milestone. label May 14, 2018
@mkArtakMSFT mkArtakMSFT added the cost: S Will take up to 2 days to complete label May 23, 2018
@mkArtakMSFT mkArtakMSFT mentioned this issue May 31, 2018
Closed
@pranavkm pranavkm assigned pranavkm and unassigned kichalla Jun 4, 2018
@pranavkm
Copy link
Contributor

pranavkm commented Jun 4, 2018

Picking this up - I got most of this done during some down time

pranavkm added a commit that referenced this issue Jun 4, 2018
@pranavkm
Create an analyzer to warn users not to decorate filters on page hand…
1292917 
…ler methods

Fixes #7684
pranavkm added a commit that referenced this issue Jun 4, 2018
@pranavkm
Create an analyzer to warn users not to decorate filters on page hand…
118e6f0 
…ler methods

Fixes #7684
@pranavkm pranavkm mentioned this issue Jun 4, 2018
Closed
pranavkm added a commit that referenced this issue Jun 4, 2018
@pranavkm
Create an analyzer to warn users not to decorate filters on page hand…
ec80cf8 
…ler methods

Fixes #7684
pranavkm added a commit that referenced this issue Jun 4, 2018
@pranavkm
Create an analyzer to warn users not to decorate filters on page hand…
a151288 
…ler methods

Fixes #7684
pranavkm added a commit that referenced this issue Jun 5, 2018
@pranavkm
Create an analyzer to warn users not to decorate filters on page hand…
fabac0e 
…ler methods

Fixes #7684
@natemcmaster natemcmaster mentioned this issue Jun 11, 2018
Closed
@natemcmaster
Copy link
Contributor

It looks like this caused templating tests to fail with new analyzer errors. See aspnet/Templating#563

This was referenced Jun 13, 2018
Merged
Closed
pranavkm added a commit that referenced this issue Jun 19, 2018
@pranavkm
Ensure analyzer package is referenced by Microsoft.AspNetCore.Mvc
37721f3 
Fixes #7684
@pranavkm pranavkm mentioned this issue Jun 19, 2018
Merged
pranavkm added a commit that referenced this issue Jun 19, 2018
@pranavkm
Ensure analyzer package is referenced by Microsoft.AspNetCore.Mvc
0d2ea2d 
Fixes #7684
pranavkm added a commit that referenced this issue Jun 19, 2018
@pranavkm
Ensure analyzer package is referenced by Microsoft.AspNetCore.Mvc
e7ab81f 
Fixes #7684
@omfgicbf omfgicbf mentioned this issue Mar 22, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done cost: S Will take up to 2 days to complete enhancement PRI: 2 - Preferred Preferably should be handled during the milestone.
Projects
None yet
Milestone
2.2.0-preview1
Development

No branches or pull requests
4 participants
@pranavkm @natemcmaster @kichalla @mkArtakMSFT