Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Allow serving Razor Pages that start with an underscore #8617

Closed
NTaylorMullen opened this issue Oct 17, 2018 · 1 comment
Closed

Allow serving Razor Pages that start with an underscore #8617

NTaylorMullen opened this issue Oct 17, 2018 · 1 comment
Assignees
@pranavkm
Labels
3 - Done bug PRI: 1 - Required Must be handled in a reasonable time
Milestone
2.2.0

Comments

@NTaylorMullen
Copy link
Contributor

Is this a Bug or Feature request?:

Bug

Steps to reproduce (preferably a link to a GitHub repo with a repro project):

  1. dotnet new razor
  2. Rename Pages/Privacy.cshtml => Pages/_Privacy.cshtml
  3. dotnet run
  4. Try hitting /_Privacy

Description of the problem:

The _Privacy Razor page is routable. However, if you were to set <RazorCompileOnBuild>false</RazorCompileOnBuild> it would not be.

/cc @pranavkm
@NTaylorMullen NTaylorMullen mentioned this issue Oct 17, 2018
Closed
@mkArtakMSFT mkArtakMSFT added 1 - Ready PRI: 1 - Required Must be handled in a reasonable time labels Oct 18, 2018
@mkArtakMSFT mkArtakMSFT added this to the 2.2.0 milestone Oct 18, 2018
pranavkm added a commit that referenced this issue Oct 18, 2018
@pranavkm
Ignore compiled view descriptors for files with leading underscore
b9c8082 
Fixes #8617
pranavkm added a commit that referenced this issue Oct 18, 2018
@pranavkm
Ignore compiled view descriptors for files with leading underscore
d758c94 
Fixes #8617
@pranavkm pranavkm mentioned this issue Oct 18, 2018
Merged
pranavkm added a commit that referenced this issue Oct 19, 2018
@pranavkm
Allow serving Razor files with leading underscore
dfb6886 
Fixes #8617
pranavkm added a commit that referenced this issue Oct 19, 2018
@pranavkm
Allow serving Razor files with leading underscore
7e5b8e5 
Fixes #8617
pranavkm added a commit that referenced this issue Oct 19, 2018
@pranavkm
Allow serving Razor files with leading underscore
7990b42 
Fixes #8617
pranavkm added a commit that referenced this issue Oct 19, 2018
@pranavkm
Allow serving Razor files with leading underscore
8a183bb 
Fixes #8617
@pranavkm pranavkm changed the title Pre-compiled Razor pages don't have underscores applied to route table correctly. Allow serving Razor Pages that start with an underscore Oct 19, 2018
@pranavkm
Copy link
Contributor

Updated title to reflect the current behavior. Any Razor file with an @page will now be served

@pranavkm pranavkm mentioned this issue Oct 19, 2018
Merged
scottaddie pushed a commit to dotnet/AspNetCore.Docs that referenced this issue Oct 19, 2018
@pranavkm @scottaddie
Update partial.md (#9132)
c123823 
React to aspnet/Mvc#8617
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done bug PRI: 1 - Required Must be handled in a reasonable time
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@pranavkm @NTaylorMullen @mkArtakMSFT