This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Tag Helpers: Add ModelExpression code generation #1291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #pragma warning disable 1998 | ||
| public override async Task ExecuteAsync() | ||
| { |
There was a problem hiding this comment.
Being empty is expected behavior for now. TagHelpers don't support DesignTime intellisense pieces so we don't generate anything for them during DesignTime.
That will be done in this issue: #1252.
added 2 commits
October 8, 2014 11:11
- Sealed the ModelExpression. - We use the stringified version of the ModelExpression type name to detect ModelExpression properties on TagHelpers. This is so the MvcRazorHost can work in tooling and in runtime. - Created a GeneratedTagHelperAttributeContext to represent the specific stringified versions of the ModelExpression assets. - Created an MvcTagHelperAttributeValueCodeRenderer to modify rendering of ModelExpression properties. #1241
- Exposed internals from Mvc.Razor.Host to Mvc.Razor.Test so it can use the MvcRazorHost override that takes the IFileSystem. - Added end-to-end code generation tests for TagHelpers with ModelExpression properties. #1241
NTaylorMullen
force-pushed
the
TagHelpers_ModelExpressionCodeGen
branch
from
b69b7bf to
4c9bce4
Compare
|
Reopening to be on TagHelpersFeature |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to validate attribute value rendering
Tag Helpers: add code generation for
ModelExpressioninstances #1241