This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Add FormTagHelper. #1323
Closed
Add FormTagHelper. #1323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private ViewContext ViewContext { get; set; } | ||
|
|
||
| [Activate] | ||
| private AntiForgery AntiForgery { get; set; } |
There was a problem hiding this comment.
This and its only call site will go away once the method for the antiforgery piece comes in.
|
⌚ |
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
5ff3854 to
3b4fe50
Compare
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
b9fb105 to
c2d3425
Compare
|
Addressed code review comments. |
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
3b4fe50 to
b1918ba
Compare
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
c2d3425 to
ba0c37a
Compare
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
2 times, most recently
from
c908f03 to
14cf681
Compare
|
Added tests. |
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
14cf681 to
07f8dda
Compare
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
be24e23 to
c175091
Compare
| /// <summary> | ||
| /// The HTTP method for processing the form, either GET or POST. | ||
| /// </summary> | ||
| public string Method { get; set; } |
There was a problem hiding this comment.
would be cleaner not to bind this attribute. just pass the default (FormMethod.Get.ToString()) to the generator. if the user has written this attribute, the copies will automatically leave that alone.
There was a problem hiding this comment.
... after offline discussion, let's not make this one different from other HTML attributes we could / do bind
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
e0a0206 to
199a8e2
Compare
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
c0b944d to
ffdae80
Compare
| } | ||
|
|
||
| // If the anti-forgery token was not specified then don't assume that it's on (user is using the | ||
| // FormTagHelper like a normal <form> tag). |
There was a problem hiding this comment.
nit: rephrase parenthetical comment. user doesn't intend to use this tag helper at all.
|
⌚ |
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
199a8e2 to
d3af121
Compare
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
ffdae80 to
4d221a1
Compare
|
Addressed code review comments. |
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
4d221a1 to
b275566
Compare
|
|
||
| if (AntiForgery ?? antiForgeryDefault) | ||
| { | ||
| var antiForgeryTag = Generator.GenerateAntiForgery(ViewContext); |
|
|
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
b275566 to
011447d
Compare
|
Will get in once previous PR's in the chain are in |
- Added the FormTagHelper. - Utilized the IHtmlGenerator to share base functionality with the HTMLHelper counterparts. - Added tests to validate FormTagHelper functionality. #1246
NTaylorMullen
force-pushed
the
TagHelpers_CopyHelpers
branch
from
e127da2 to
b7a38c3
Compare
NTaylorMullen
force-pushed
the
TagHelpers_Form
branch
from
011447d to
3e2c256
Compare
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag Helpers:
<form/>tag helper #1246