This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Log exceptions in JsonInputFormatter #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,6 +72,9 @@ public override Task<InputFormatterResult> ReadRequestBodyAsync(InputFormatterCo | |||
| return InputFormatterResult.FailureAsync(); | |||
| } | |||
|
|
|||
| var loggerFactory = context.HttpContext.RequestServices.GetRequiredService<ILoggerFactory>(); | |||
| var logger = loggerFactory.CreateLogger<FileResult>(); | |||
There was a problem hiding this comment.
We should be passing this in the constructor.
ryanbrandenburg
force-pushed
the
rybrande/JsonInputLogging
branch
from
2450bae to
9f4c671
Compare
| It.IsAny<object>(), | ||
| It.IsAny<Exception>(), | ||
| It.IsAny<Func<object, Exception, string>>()), | ||
| Times.Once); |
There was a problem hiding this comment.
This formatting hurts my eyes. What is this testing, anyway?
There was a problem hiding this comment.
That when we have an error coming out of the formatter we log the error in addition to returning it. I suppose it's probably mostly paranoia on my to double check that the logging happened, I'll remove it.
There was a problem hiding this comment.
Maybe just fix the indentation then? The Times.Once can't be on the same line as Mock.Get.
Try something like:
Mock
.Get<ILogger>(logger)
.Verify(l => l.Log(
LogLevel.Verbose,
It.IsAny<int>(),
It.IsAny<object>(),
It.IsAny<Exception>(),
It.IsAny<Func<object, Exception, string>>()),
Times.Once);
ryanbrandenburg
force-pushed
the
rybrande/JsonInputLogging
branch
from
ce5cb8a to
10bde5c
Compare
|
🆙 📅 |
|
|
ryanbrandenburg
force-pushed
the
rybrande/JsonInputLogging
branch
2 times, most recently
from
713ea13 to
96d4bed
Compare
ryanbrandenburg
force-pushed
the
rybrande/JsonInputLogging
branch
from
96d4bed to
91e837d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3557.