This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Quick fix: Clean up test warnings #8660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Oct 28, 2018
| return new LinkBuilder(url); | ||
| } | ||
|
|
||
| protected virtual void ConfirmNotFoundOrNotAllowed(HttpResponseMessage response) |
There was a problem hiding this comment.
nit: Assert... instead of Confirm...
There was a problem hiding this comment.
I think the name could be more descriptive: AssertCorsRejectionStatusCode
rynowak
approved these changes
Oct 28, 2018
JamesNK
approved these changes
Oct 28, 2018
| return new LinkBuilder(url); | ||
| } | ||
|
|
||
| protected virtual void ConfirmNotFoundOrNotAllowed(HttpResponseMessage response) |
There was a problem hiding this comment.
I think the name could be more descriptive: AssertCorsRejectionStatusCode
- avoid "Skipping test case with duplicate ID" messages - xUnit gets confused when `[Theory]`s are overridden - avoid "falling back to single test case" messages - fix inspired by aspnet/SignalR#1820
dougbu
force-pushed
the
dougbu/run.all.tests
branch
from
79de3db to
6fef038
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Theory]s are overridden