This repository was archived by the owner on Dec 14, 2018. It is now read-only.
Add integration and functional tests of [BindRequired] on page properties
#8677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
commented
Oct 31, 2018
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly: InternalsVisibleTo("Microsoft.AspNetCore.Mvc.Test, PublicKey=0024000004800000940000000602000000240000525341310004000001000100f33a29044fa9d740c9b3213a93e57c84b472c84e0b8a0e1ae48e67a9f8f6de9d5f7f3d52ac23e48ac51801f1dc950abe901da34d2a9e3baadb141a17c77ef3c565dd5ee5054b91cf63bb3c6ab83f72ab3aafe93d0fc3c2348b764fafb0b1c0733de51459aeab46580384bf9d74c4e28164b7cde247f891ba07891c9d872ad2bb")] | ||
| [assembly: InternalsVisibleTo("Microsoft.AspNetCore.Mvc.IntegrationTests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100f33a29044fa9d740c9b3213a93e57c84b472c84e0b8a0e1ae48e67a9f8f6de9d5f7f3d52ac23e48ac51801f1dc950abe901da34d2a9e3baadb141a17c77ef3c565dd5ee5054b91cf63bb3c6ab83f72ab3aafe93d0fc3c2348b764fafb0b1c0733de51459aeab46580384bf9d74c4e28164b7cde247f891ba07891c9d872ad2bb")] |
There was a problem hiding this comment.
This is for PageBinderFactory
|
|
||
| var message = new HttpRequestMessage(HttpMethod.Post, "/CustomModelTypeModel"); | ||
| message.Content = new FormUrlEncodedContent(new Dictionary<string, string> | ||
| var message = new HttpRequestMessage(HttpMethod.Post, "/CustomModelTypeModel") |
There was a problem hiding this comment.
The other tests using /CustomModelTypeModel aren't affected by the validation failure.
| { | ||
| // Arrange | ||
| var getPage = await Client.GetAsync("/CustomModelTypeModel"); | ||
| var getPage = await Client.GetAsync("/CustomModelTypeModel?Attempts=0"); |
There was a problem hiding this comment.
This isn't strictly necessary because the OnGet(...) handler doesn't check ModelState.IsValid.
|
Closing and reopening to nudge the CLA check along |
pranavkm
approved these changes
Oct 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BindingBehavior]applied to page model properties #7353