Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

Move the netcoreapp2.0 runtime library into the build folder #143

Closed
NTaylorMullen opened this issue Jun 13, 2017 · 11 comments
Closed

Move the netcoreapp2.0 runtime library into the build folder #143

NTaylorMullen opened this issue Jun 13, 2017 · 11 comments
Assignees
Milestone

Comments

@NTaylorMullen
Copy link
Contributor

This way a users application can't actually call into ViewCompilation code.

@Eilon this should be done for RTM

@pranavkm
Copy link
Contributor

Might have to check this one - if you have a lib\net451, but no lib\netcoreapp2.0, you might not be able to install the package in a netcoreapp targeting project. That said, there's no API exposed by the assembly and it's not meant to be deployed PrivateAssets="true", so there's not a lot of risk of application code calling in to it.

@Eilon
Copy link
Member

Eilon commented Jun 15, 2017

With the new PTF vs. ATF thing I don't know what the behavior would be.

@NTaylorMullen
Copy link
Contributor Author

With the new PTF vs. ATF thing

What's PTF vs. ATF?

@Eilon
Copy link
Member

Eilon commented Jun 15, 2017

PackageTargetFallback vs. AssetTargetFallback.

@Eilon
Copy link
Member

Eilon commented Jun 15, 2017

Not saying it's necessarily related, but it might be relevant.

@natemcmaster
Copy link
Contributor

Btw, same is true of the .NET Framework assembly. These are currently packed into runtimes/win-{x64, x86}/lib/, which means NuGet treats this as available assemblies. Would be better to put all these console tools in a non-asset folder. Our other tooling packages put these into tools/ or toolsassets/ to ensure NuGet ignores them.

@NTaylorMullen
Copy link
Contributor Author

NTaylorMullen commented Jun 15, 2017

Today we do this because we rely on the CLI to auto-generate binding redirect files for those guys. We could manually create binding redirects (and pack them) that would work with most apps to move those bits around.

@natemcmaster
Copy link
Contributor

The binding redirects can't be packed. You have to generate those based on the dependencies of the project.

FWIW - it's more complicated, but you could "borrow" the binding redirects generated for the app, or use AppDomains to better manage assembly resolution.

@Eilon
Copy link
Member

Eilon commented Jun 19, 2017

We need to talk to @DamianEdwards about some aspects of this because it seems like we're having to work around too many sharp edges in the system.

@pranavkm
Copy link
Contributor

Binaries moved. @Eilon do you want me to keep the work item open so we can follow up with @DamianEdwards?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants